-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx211 Modify the tests and try to put tests in HGCal Geometry area #27739
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27739/11376
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@kpedro88 - please review |
@ianna I did send you an email about one of the existing algos in a separate mail. Could you please take a look into this |
@kpedro88 this PR involves only test and developments geometries, and it looks ok to me to move forward |
+1 |
merge |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Modify the tests and test DD4Hep algorithms using similar xml files as for DDD
PR validation:
Make use of private tests
if this PR is a backport please specify the original PR:
Nothing special